Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing getBluetoothAuthorizationStatuses from Diagnostic #4432

Closed
1 of 3 tasks
si458 opened this issue Nov 17, 2022 · 2 comments · Fixed by #4442
Closed
1 of 3 tasks

missing getBluetoothAuthorizationStatuses from Diagnostic #4432

si458 opened this issue Nov 17, 2022 · 2 comments · Fixed by #4442

Comments

@si458
Copy link
Contributor

si458 commented Nov 17, 2022

I'm submitting a ... (check one with "x")

Current behavior:

getBluetoothAuthorizationStatuses is missing from the diagnostics module

Expected behavior:

getBluetoothAuthorizationStatuses to exist

Steps to reproduce:

Related code:

insert any relevant code here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

insert the output from ionic info here
@si458 si458 changed the title missing getBluetoothAuthorizationStatuses from diagnostics missing getBluetoothAuthorizationStatuses from Diagnostic Nov 17, 2022
@infacto
Copy link
Contributor

infacto commented Nov 24, 2022

@infacto
Copy link
Contributor

infacto commented Nov 24, 2022

I made a pull request.

Btw. we should avoid any types. I know this is not always that easy. Since the source code or docs are also a bit cryptic. In this case it returns an object with permission name as key and the permission state as value. In typescript Record<string, string> or better with enum or specific type instead of just string. But we must be 100% sure when restricting with types. Anyway, it's another issue. It would be great if someone could review and merge the pull reqeust and file a new release.

Another wild idea is to allow custom methods to call with the same Promise like behavior. Useful if the wrapper is not sync with the latest cordova plugin version. Helpful as a temp solution. Otherwise I have to craft my own using cordova.plugins[name] etc. and wrap into Promise. It's a bit more ugly work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants