Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hoc should be lowercase. #49

Closed
bentatum opened this issue Sep 6, 2016 · 2 comments
Closed

hoc should be lowercase. #49

bentatum opened this issue Sep 6, 2016 · 2 comments

Comments

@bentatum
Copy link
Contributor

bentatum commented Sep 6, 2016

sortable(ListItem)

...so folks don't confuse it with a regular component

<Sortable><ListItem/></Sortable>
@ladas-larry
Copy link
Collaborator

It's there now.

@janstuemmel janstuemmel mentioned this issue Oct 25, 2016
Merged
@maackle
Copy link

maackle commented Nov 16, 2016

This is a breaking change that got applied to a minor version update, which violates semver. I think the right thing to do would have been to keep the original uppercase Sortable as a deprecated alias until 2.0. We just had our build break because of this. Not a big deal, but just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maackle @ladas-larry @bentatum