Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a mistake in server/election.go #18

Open
moooofly opened this issue Sep 14, 2022 · 2 comments
Open

Find a mistake in server/election.go #18

moooofly opened this issue Sep 14, 2022 · 2 comments

Comments

@moooofly
Copy link

Hi, I think there is a mistake in server/election.go#L235

should be

	if !ok {
		s.logger.Infof("leader %s does not exist", s.leaderID)
		return false                   <--- here
	}

am I right?

@adesokanayo
Copy link
Contributor

that's correct, that should be false. You can make a PR to fix it.

@malwaredllc , are you happy to accept some hacktoberfest PR on this project. If yes, you can add it using this Guide

@danielvegamyhre
Copy link
Owner

@moooofly Sorry for the delayed response, feel free to submit a PR with the fix! (Ideally with a test case that will catch this next time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants