Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make using TLS optional #5

Closed
malwaredllc opened this issue May 16, 2022 · 2 comments
Closed

Make using TLS optional #5

malwaredllc opened this issue May 16, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@malwaredllc
Copy link
Collaborator

Currently using TLS is required - if the TLS certificates do not exist in the certs/ directory, or if the node's current hostname/IP is not listed in the TLS certificate SANs (subject alternate names), then the connection will fail at the TLS step.

Using TLS should be optional, perhaps with a command line flag when launching the server, or as a value in a config file.
@malwaredllc malwaredllc added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 16, 2022
@alvinlee001
Copy link
Contributor

alvinlee001 commented May 16, 2022 •
edited
Loading

HI @malwaredllc, i think i managed to make this work as well, with either command line parameter flag
--client-auth=false with default of value true, and also available in json file as client_auth... it should work both on gRPC and REST.

it is also in the same pull request

@malwaredllc
Copy link
Collaborator Author

Closed by #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alvinlee001 @malwaredllc