Add authorization token to file system api #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinFournier
force-pushed
the
feature/http-server-auth
branch
from
8bd51e2
to
5d7d72a
Compare
Gracefully handle http-server start error & cleanup logs
hexnaught
added a commit
to hexnaught/vscode-bitburner-connector
that referenced
this pull request
Dec 29, 2021
Changes to the extension to support setting a required 'auth token' genearated by the game, needed by us in order to push files to the games HTTP server. - New command: 'Add Auth Token' - New config/setting contribution: 'bitburner.authToken' - Extension shows error when files are attempted to be pushed, or the filewatcher is attempted to be started when no auth token is set. - Update readme with no auth flow/process and how-to See: danielyxie/bitburner#2218
|
As per linked PR. Changes in the extension to support this, if this type of auth is to be used. hexnaught/vscode-bitburner-connector#4 Branch README with more information. The PR description should cover it though. |
hexnaught
added a commit
to hexnaught/vscode-bitburner-connector
that referenced
this pull request
Dec 30, 2021
* feat(auth): Add requirement for auth token Changes to the extension to support setting a required 'auth token' genearated by the game, needed by us in order to push files to the games HTTP server. - New command: 'Add Auth Token' - New config/setting contribution: 'bitburner.authToken' - Extension shows error when files are attempted to be pushed, or the filewatcher is attempted to be started when no auth token is set. - Update readme with no auth flow/process and how-to See: danielyxie/bitburner#2218 * docs(README): update table of extension config options
github-actions bot
pushed a commit
to hexnaught/vscode-bitburner-connector
that referenced
this pull request
Dec 30, 2021
# [1.3.0-develop.1](v1.2.1-develop.1...v1.3.0-develop.1) (2021-12-30) ### Features * **auth:** Add requirement for auth token ([#4](#4)) ([b2d40a1](b2d40a1)), closes [danielyxie/bitburner#2218](danielyxie/bitburner#2218)
github-actions bot
pushed a commit
to hexnaught/vscode-bitburner-connector
that referenced
this pull request
Dec 30, 2021
# [1.3.0](v1.2.1...v1.3.0) (2021-12-30) ### Features * **auth:** Add requirement for auth token ([#4](#4)) ([b2d40a1](b2d40a1)), closes [danielyxie/bitburner#2218](danielyxie/bitburner#2218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled http server by default on game start.
Added a new menu item to start or stop the http server.
Added a menu item to enable or disable automatic http server start on game launch.
Now requires a bearer token in the headers of the requests.
The token is generated on first launch and stored in local game files (%APPDATA%/bitburner/config.json on Windows).
Added a menu item to copy the token to the clipboard.
The extension will have to add a setting to store this token on their side and add it to the request header