Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the nortek aquadopp "orientation" field change during a deployment? #1761

Open
richardsc opened this issue Dec 15, 2020 · 12 comments
Open
Assignees
Labels
adp cm pinned Prevent automatic stale designation

Comments

@richardsc
Copy link
Collaborator

richardsc commented Dec 15, 2020

Following on from #1758 (comment)

Oh, and I see the "orientation" field IS there, it's just been renamed to be orientation, rather than configTiltSensorOrientation ...

    if (missing(orientation)) {
        orientation <- header$head$configTiltSensorOrientation # FIXME: is there a 'header$head'?
    } else {
        orientation <- match.arg(orientation, c("sideward", "upward", "downward"))
    }

One concern I have about this (which was an issue with RDI instruments, I believe), is that we are treating this field as a constant for the entire file, whereas it may actually vary depending on how the orientation changes. For example, if the instrument was lying on its side on deck before deployment, it might register that as "downward" even if it ends up deployed in an "upward" position. I'd better open a separate issue for this (and debug by checking the instrument logs, which I'm waiting for from our field group).

@richardsc richardsc self-assigned this Dec 15, 2020
@stale
Copy link

stale bot commented Dec 31, 2020

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next week (or the 'pinned' label is applied), this issue will be closed automatically in a week.

@stale stale bot added the stale label Dec 31, 2020
@richardsc richardsc removed the stale label Jan 1, 2021
@richardsc
Copy link
Collaborator Author

Slow down stale bot -- it's the holidays!

@dankelley
Copy link
Owner

I just doubled both time criteria.

@richardsc richardsc assigned dankelley and unassigned richardsc Jan 21, 2021
@dankelley
Copy link
Owner

A reminder: I'll need a sample file. (To prevent concern over missing-mail problems, please note that I'll email back when you send it.)

@richardsc
Copy link
Collaborator Author

Sent.

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next two weeks (or the 'pinned' label is applied), this issue will be closed automatically in a week.

@stale stale bot added the stale label Jun 11, 2021
@richardsc richardsc removed the stale label Jun 11, 2021
@richardsc
Copy link
Collaborator Author

Removing the stale label, as I am waiting for @dankelley to have a look at the sample file that I sent. There isn't a big rush for this, but it probably shoudn't just disappear.

@dankelley
Copy link
Owner

I imagine you knew I was going to ask this, but can you resend the sample file? I don't track emails well (by which I mean that I delete old emails aggressively), and unless I put files into a subdirectory in the oce-issues repo, I don't know where to look. I tried as below (guessing a filename from #1758) but got no hits.

find ~ -name 205413.AQD -print

@richardsc
Copy link
Collaborator Author

Sent (again 😄 ). Filename is aqd9330.aqd.

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next two weeks (or the 'pinned' label is applied), this issue will be closed automatically in a week. Please note that this is not a reflection on the quality or importance of the issue, but merely a reminder of the march of time. A simple comment is all it takes to keep this issue from being closed automatically, two weeks from now.

@stale stale bot added the stale label Jul 21, 2021
@dankelley
Copy link
Owner

I'm commenting to keep this issue alive. I keep forgetting about it, sorry.

@stale stale bot removed the stale label Jul 21, 2021
@stale
Copy link

stale bot commented Apr 17, 2022

An automated message from the stale bot -- this issue has been marked as stale because no comments have been made in 30 days. The goal of this action is to remind reporter and developers alike that progress seems to have stalled. Please note that the issue will be automatically closed 30 days from now, unless a comment is made, or the pinned label is applied. Thank you.

@stale stale bot added the stale label Apr 17, 2022
@dankelley dankelley added pinned Prevent automatic stale designation and removed stale labels Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp cm pinned Prevent automatic stale designation
Projects
None yet
Development

No branches or pull requests

2 participants