Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no warnings 'redefine'; and correctly load dependences #106

Merged
merged 1 commit into from
Jun 1, 2017

Commits on May 31, 2017

  1. Remove no warnings 'redefine'; and correctly load dependences

    Calling no warnings 'redefine'; just hide a read problem that one function
    is later redefined by another. Such thing should not happen, and if there
    is it should be fixed.
    
    The real problem is exporting all Encode functions into used modules,
    including functions encode() and decode(). Correct way is to export only
    those functions which are really needed by modules. Or to call Encode
    function with whole package name (e.g. Encode::find_encoding).
    
    Another problem is time when Encode module is loaded. By calling require it
    is done at runtime, after current file was already parsed. It is too late
    specially for prototyped functions and also constant. Calling use instead
    of require fixes this problem.
    
    After those fixes no warnings 'redefine'; can be removed and modules are
    warning-free.
    pali committed May 31, 2017
    Configuration menu
    Copy the full SHA
    55364c9 View commit details
    Browse the repository at this point in the history