Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Encode::utf8 #97

Merged
merged 4 commits into from
Apr 21, 2017
Merged

Fixes for Encode::utf8 #97

merged 4 commits into from
Apr 21, 2017

Commits on Apr 20, 2017

  1. Encode::utf8: decode: Error message now contains original source sequ… 

    …ence

Before this patch in error message was partially decoded Unicode codepoint.
That does not make any sense as invalid UTF-8 sequence cannot be correctly
decoded to one Unicode codepoint. And original sequence (in hex) is better
for investigation.

After this change error message for invalid UTF-8 sequence when decoding
will contain original invalid sequence in hex format.

Similarly fallback coderef for decode will now contains in @_ arguments
whole invalid UTF-8 sequence and not only first invalid byte. This could
allow applications which uses Encode::decode to look at whole invalid UTF-8
sequence, not only at first byte. Before this change fallback coderef was
called only with one argument, so this change should be backward compatible
for coderefs which look only at $_[0].

Bug: https://rt.cpan.org/Public/Bug/Display.html?id=36348
    @pali
    pali committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    dc4214d View commit details
    Browse the repository at this point in the history

  2. Encode::utf8: Error message in strict mode now contains "UTF-8" 

    Before this patch in error message was "utf8" as name of encoding. Now name
in error message is chosen by strict mode. Either "UTF-8" or "utf8".
    @pali
    pali committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    c1bbfc0 View commit details
    Browse the repository at this point in the history

  3. Encode::utf8: Remove defines for UTF8_ALLOW_STRICT and UTF8_ALLOW_NON… 

    …STRICT

They are not needed as they are not used anymore...
    @pali
    pali committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    2fd6264 View commit details
    Browse the repository at this point in the history

  4. Encode::utf8: Fix applying correct UTF-8 start mask for pathological … 

    …invalid sequences
    @pali
    pali committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    bb60a14 View commit details
    Browse the repository at this point in the history