set_stay_off service does not work

[danobot]

Description

Service entity_controller.set_stay_off does not work according to mention in #164 .
@dexn please add details here to track the issue

Configuration

Include configuration of affected entity.

Steps to reproduce

Steps to reproduce the behavior:

Expected behavior

A clear and concise description of what you expected to happen.

Actual Behaviour

Logs

Provide logs at DEBUG level.

Version

If you are not using the latest version, please upgrade first.

[danobot]

@xannor Any idea what might cause this? It was added in this PR

[xannor]

All the service did is toggle the Model.stay value between true and false depending in which was called is called. The rest is up to the Model object and the things that use it. It could be that nothing re-checks or notifies that the value has changed, and I am not sure how those are tracked between Model and Machine.

[danobot]

Did this feature work correctly when you first implemented it?

[xannor]

I remember testing whether I could toggle the mode on, but I cannot recall explicitly testing toggling it off. I may have assumed that since I could toggle it on it would toggle off as well. I think it mostly comes down to the Machine object and how it detects a property change. I am not overly familiar with python, I have more of a basis in .Net and C#, so I do not know what sort of property hooks or events python may support. I am also not familiar with the Machine object and the code behind it so I do not know if it may need something to notify it of a property change. The on tests may have worked because of other interactions forcing an update.

[danobot]

ok it sounds like it was never implemented other than a placeholder and therefore not supported. closing this issue.