-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC configurations do not load properly in 2024.2.0 - may be Python 3.12 #320
Comments
Hi, I've added the debug line to configuration.yaml for each entity controller but it's not working, yet I still see lots of debug records in the log. Have I entered the debug line incorrectly?
|
I'm not sure what you are talking about, @m90att ? In my case, "debug on" means this line in configuration.yaml
I can't tell what behavior you are experiencing. Are you saying it stopped working for you as well? did you see the errors like this?
|
@robchandhok yes, it stopped working for me when I upgraded to 2024.2 beta. I came to the EC github page to see if an issue had been raised and that's how I got here. Reading your issue I understand that the config isn't loading if debug is off and that the workaround to get it to work is to "set custom_components.entity_controller: debug". Having never set debug I referred to the HA Logger page and it suggested adding lines according to this format
...so that's what I did. I expected this to fix the issue as yours did but it hasn't, so I pasted the logs I saw showing that the errors are still seen. I was just seeking clarification that what I had added to my configuration.yaml was correct. |
Unfortunately I have re-tested, include a full hard restart of my entire PC running Home Assistant (HAOS) and even with debug on, it doesn't do the right thing. I misunderstood that the debug message about "initializing with this configuration" showing the correct config did NOT mean it was parsed correctly. There are still errors later in the log file (shown below). The controller that is created is basically empty. I'm back to thinking it's a Python update related bug where the type name has somehow changed.
|
Just reverted to 9.6.1, and the problem goes away. The big difference is that 9.7.1 has the YamlObjects checks, which fail in the beta. @m90att if you want a workaround, you can use this call in the developer tools/services to revert to 9.6.1 (you have to use the hash of the version, not the tag, for some reason). And of course restart after.
|
Having similar issue. Had to downgrade Home Assistant. Using the update.install service did not work to resolve the issue. Does adding the custom_components.entity_controller: debug to config work? I did not try that. |
@pageb018 Sorry but upon further review I realized I made a mistake - the debug setting has no impact on it working. When 2024.2 comes out (today I think) I will try and re-check with 9.7.1 of EC. I did mention the issue in the HA Discord for the beta, but no one had seen anything. |
I am sorry to report the problem still exists in 2024.2.0 :-( A quick fix would be to remove the type checking using YamlObject, which I'm happy to do, but hopefully @danobot can weigh in as this will affect everyone. |
Thank you for your efforts @robchandhok I'll continue to use my back up HA automations until I hear more. |
@robchandhok please could you tell me more about the quick fix? |
Hi @stefanoferrario . My read of the bug/failure is this line, the type comparison fails:
This code was introduced in the fix for #316/#317, but I suspect that since the update to python in this release, something changed that makes the Type comparison incorrect. It could be a defect in YamlObjects() or something just changed. You can see in my earlier logs I posted that it falls through the if/elif... and reports that it doesn't think a list is a list :-)
If Hope this is clear? |
Thanks! As workaround I try downgrade to 9.4.0 version and the problem goes away |
Yes, that code is not in 9.4.0 |
Can you outline the steps for downgrading? |
@pageb018 as suggested by @robchandhok you can use this call in the developer tools/services to revert to previous version. And of course restart after.
As version you have to use 9f67d63 for 9.4.0 version. |
Hi, how do I check what version is installed. I ran the update.intall service to downgrade and then restarted but I'm not seeing any difference. I'd like to check that it downgraded properly. |
I have a fix BTW. Just putting the PR together. |
If you are technical enough, you can grab the single changed file in this PR and test, but it fixes it cleanly for me. |
Thank you @stefanoferrario and @kzaoaai, I've learned something new 😃 |
If it is useful to anyone else or you want to TEST the fix, you can point HACS at this custom repository: https://github.com/robchandhok/entity-controller and use that. ONLY DO THIS IF YOU ARE COMFORTABLE DOING IT Steps are:
It has the fixes merged so until the author has time to merge, this will work. After that you should delete the custom repository as I am not promising it will stick around forever. Cheers! |
Thank you for this, it is working for me again. |
You can update to the latest version, I merged @robchandhok 's PR :) |
ok now I am getting repository not found @robchandhok in HACS, want to delete your and install the master one again, any idea how? |
Hi. Yes I delete my temporary release so there wasn't any confusion going forward. If you delete my repository from your "custom repositories " in HACS you will be able to see the main repository release again. Make sure you see 9.7.2! |
Description
The latest version of EntityController, and the latest (beta) HA release seems to trigger a behavior that makes config file parsing fail
when DEBUG is off for the EntityController component.Configuration
Steps to reproduce
Steps to reproduce the behavior:
3. Set custom_components.entity_controller: debug 4. Entity Controller loads properly (and verbosely)Expected behavior
This is how the component should work:
Actual Behaviour
This is what actually happened:
when debug is false. I looked for something being changed, the biggest change is this HA build uses Python 3.12.Logs
Version
The text was updated successfully, but these errors were encountered: