Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on first run #3

Open
kennethkufluk opened this issue May 19, 2011 · 1 comment
Open

Tests fail on first run #3

kennethkufluk opened this issue May 19, 2011 · 1 comment

Comments

@kennethkufluk
Copy link
Collaborator

Because of the mkdir.

@fat
Copy link
Collaborator

fat commented May 19, 2011

exec (which is how you're doing mkdir) is async -- and you're test assumes loadbuilder is completely sync. You should either give loadbuilder a callback, or write mkdir -p to be sync.

However, small question -- why write loadbuilder sync? You could avoid some try catches and other ugliness if you did it async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants