diff --git a/container/code/evaluate.py b/container/code/evaluate.py index 1599710..a670060 100644 --- a/container/code/evaluate.py +++ b/container/code/evaluate.py @@ -83,7 +83,29 @@ def inspect_output(): logger.info(f"Extracting model from path: {model_path}") with tarfile.open(model_path.as_posix()) as tar: - tar.extractall(path=EvalConfig.IN_MODEL_DIR) + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=EvalConfig.IN_MODEL_DIR) inspect_input() evaluate()