Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move distributed data structures and kernels to src/runtime/distributed/ #96

Closed
daphne-eu opened this issue Jul 30, 2021 · 0 comments · Fixed by #428
Closed

Move distributed data structures and kernels to src/runtime/distributed/ #96

daphne-eu opened this issue Jul 30, 2021 · 0 comments · Fixed by #428

Comments

@daphne-eu
Copy link
Owner

In GitLab by @pdamme on Jul 30, 2021, 18:59

The distributed data structures (Handle.h) and kernels (Distribute.h, DistributedCompute.h, and DistributedCollect.h) currently reside in src/runtime/local/. However, they clearly belong to the distributed run-time. Thus, the directories src/runtime/distributed/datastructures and src/runtime/distributed/kernels should be created and those files moved there.

This necessitates changes to genKernelInst.py and kernels.json, since these currently assume local kernels. We could add a boolean flag isDistributed to all kernels in kernels.json (or genKernelInst.py could just check if the kernel header resides in local or distributed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant