Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding AWS Kinesis - reuse client credentials #3508

Open
soisyourface opened this issue Aug 28, 2024 · 3 comments
Open

Binding AWS Kinesis - reuse client credentials #3508

soisyourface opened this issue Aug 28, 2024 · 3 comments

Comments

@soisyourface
Copy link
Contributor

Describe the proposal

Currently when creating a Kinesis binding, at least locally, you must pass in the "static credentials" for the secret(key, id, session?). This is not an ideal experience.

Propose that when creating the KCL for Kinesis that we use the existing AWS client credentials instead of remaking them.

If a complete replacement isn't wanted, then perhaps only using the existing client credentials will be used if the static credentials aren't defined in the config.

@yaron2
Copy link
Member

yaron2 commented Sep 6, 2024

This is definitely a good idea and we're doing the same for a lot of our other AWS components - please see how we reuse and handle authentication in AWS SQS for example

Copy link

github-actions bot commented Oct 6, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 6, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
@yaron2 yaron2 reopened this Oct 13, 2024
@github-actions github-actions bot removed the stale label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants