Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings from ng9 build #50

Closed
CarstenLeue opened this issue Feb 25, 2020 · 2 comments
Closed

Warnings from ng9 build #50

CarstenLeue opened this issue Feb 25, 2020 · 2 comments

Comments

@CarstenLeue
Copy link

When pulling in the browser version of ng2-logger in an ng9 ivy build I get this warning:

WARNING in Entry point '@acoustic-content-sdk/ng-logger' contains deep imports into '/usr/build/sites/node_modules/ng2-logger/browser'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

I think this is because ng2-logger/browser does not contain its own package.json file. Could you consider representing ng2-logger/browser using a secondary entry point instead of having to use deep imports?

https://github.com/ng-packagr/ng-packagr/blob/master/docs/secondary-entrypoints.md

@darekf77
Copy link
Owner

( Sorry for delay ) Sure... in next version there will be package .json for /browser.

@darekf77
Copy link
Owner

darekf77 commented Jun 1, 2020

Now... from version 3.0.12 there is package.json in browser or client folder.

@darekf77 darekf77 closed this as completed Jun 1, 2020
@darekf77 darekf77 pinned this issue Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants