Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible refactor of p2p behaviour #3

Closed
dariusc93 opened this issue Sep 3, 2022 · 0 comments
Closed

Possible refactor of p2p behaviour #3

dariusc93 opened this issue Sep 3, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@dariusc93
Copy link
Owner

Due to changes in libp2p related to NetworkBehaviour from libp2p/rust-libp2p#2842, structs implementing the trait would not be able to have ignored fields, which is being used https://github.com/dariusc93/rust-ipfs/blob/next/src/p2p/behaviour.rs#L50-L53 . As a result, changes would need to be done so they are on the outside of the struct

@dariusc93 dariusc93 added the enhancement New feature or request label Sep 3, 2022
@dariusc93 dariusc93 self-assigned this Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant