-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA RACE in Souin #576
Comments
Hey @christophcemper I see that you're using I'll write a unit test/integration test and see if it reproduces the data race. From the logs: |
Thanks for the quick response @darkweak ! Here's another DATA RACE based on Caddy v2.8.4 but not newer souin, for you and Matt hopefully helpful
|
and a 2nd one just came
|
here is a DATA RACE using the latest cache-handler 0.15.0 which uses souin 1.7.5
Tracked and built internally here with v2.8.4-rwmutexplus4-cache-0.15.0-souin1.7.5
|
Hey @christophcemper can you try with the commit
|
We keep getting DATA RACE conditions (or total crashes and outages that require manual restarts in the middle of the night)
and besides other issues with concurrency suspected in Vars Middleware, Replacer, Matcher
also the (newly in us) cache-handler/souin "middleware" is one of the suspects.
It's possible that this happened in a "HTTP-Connection-Destructor" or similar related to closing a lot of open tabs, but I could be totally wrong.
Posting this here for future reference:
Not able to spend more time on collecting all "standard" details, as it's obvious that none of them help reproduce such rare issues, until we have a way to reproduce both data+timing in a consistent way.
The fork/build used is this one, which already. uses rwmutex + for the Vars Middleware so at least some potential problems can be excluded.
We've seen more Cache/Souin-related DATA RACE problems, as mentioned, but only on local builds.
so
The text was updated successfully, but these errors were encountered: