Sets unsafe headers

[bergwerf]

I use this library to generate client code for my own API that I wrote using rpc. The generated code tries to set Content-Length and User-Agent on the requests. However these headers are considered unsafe by the browser. I think it would be appropriate to at least have an option to not set these headers.

[mkustermann]

The generator emits code which is used on web and non-web applications, so generally speaking setting the content-length and user-agent headers is understandable.

Generated Api classes accept an http.Client: The workaround at the moment is to make a wrapper of http.Client which removes the two headers and sends the request to the underlying http.Client.

[bergwerf]

Right. So you suggest overriding BrowserClient.send and removing both headers from the header map before calling the super method?

[bergwerf]

For future reference, I now use this code which works without issues for my use cases.

class ApiBrowserClient extends BrowserClient {
  @override
  Future<StreamedResponse> send(request) {
    request.headers..remove('content-length')..remove('user-agent');
    return super.send(request);
  }
}

[jakuub]

We are using almost the same code for approximetly one year, and everything works fine for us too.