-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build and serve APIs to make use of package:build_daemon #352
Comments
For now this is probably enough, but we need to come up with a design for the testing story as well, and that will require running a separate test command most likely while a regular build/serve are happening? |
Yeah I think eventually we'll want to make them cooperate across processes somehow |
A simple mechanism could be a |
yes for now something like that would be an improvement |
Moving to M1, you have to be a bit careful about how you use watch/serve together with test today (among other scenarios) but solving this properly is going to take some work. |
@jakemac53 can you elaborate on what you mean by
What I'm seeing right now (and the core team that works on https://github.com/Workiva/over_react are trying to figure out) is... is it actually possible to be serving, lets say - the Any guidance / current workarounds would be very appreciated and welcome. cc/ @robbecker-wf @evanweible-wf @corwinsheahan-wf @greglittlefield-wf |
@aaronlademann-wf right now the only safe thing to do is kill the other server before running tests - which is obviously not a great solution. However, @grouma has been actively working on the build_daemon which solves this problem (there is already a This is a fairly fundamental change and there will be some restrictions - for instance you won't be able to provide different build flags from different clients (it will ask you to kill the existing server in that case before running tests). |
Assigning Gary as he has been the one working on this, I forgot we actually had an issue filed :). |
No description provided.
The text was updated successfully, but these errors were encountered: