Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http_client_conformance_tests] Add close behavior test #1192

Open
Zekfad opened this issue May 4, 2024 · 1 comment
Open

[http_client_conformance_tests] Add close behavior test #1192

Zekfad opened this issue May 4, 2024 · 1 comment
Labels
package:http type-enhancement A request for a change that isn't a bug

Comments

@Zekfad
Copy link
Contributor

Zekfad commented May 4, 2024

Coming from Zekfad/fetch_client#18

I've fixed issue on a client implementation end but it hints that there should be a test that closing client cleans up it and terminates associated connections.

Also this is mostly the same for recently merged #1191
@Zekfad Zekfad added package:http type-enhancement A request for a change that isn't a bug labels May 4, 2024
@brianquinlan
Copy link
Collaborator

Great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:http type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianquinlan @Zekfad