Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Commit

Permalink
Enable a test that was skipped due to an old browser
Browse files Browse the repository at this point in the history
Add missing dependency in pubspec
Remove unneeded dart_test.yaml file

PiperOrigin-RevId: 338101758
  • Loading branch information
kevmoo committed Oct 20, 2020
1 parent 6e8fc59 commit 32844f3
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 31 deletions.
19 changes: 0 additions & 19 deletions dart_test.yaml

This file was deleted.

1 change: 1 addition & 0 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies:

dev_dependencies:
fixnum: '>=0.9.0 <0.11.0'
js: 0.6.3-nullsafety
test: ^1.16.0-nullsafety.4

dependency_overrides:
Expand Down
19 changes: 7 additions & 12 deletions test/number_format_compact_web_test.dart
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
/// Tests for compact number formatting in pure Dart and in ECMAScript.
///
/// TODO(b/36488375): run all these tests against both implementations to prove
/// consistency when the bug is fixed. Also fix documentation and perhaps
/// merge tests: these tests currently also touch non-compact currency
/// formatting.
/// We use @Tags rather than @TestOn to be able to specify something that can be
/// ignored when using a build system that can't read dart_test.yaml. This
/// depends on https://github.com/tc39/proposal-unified-intl-numberformat.
@Tags(['unifiedNumberFormat'])

@TestOn('browser')
// Tests for compact number formatting in pure Dart and in ECMAScript.
//
// TODO(b/36488375): run all these tests against both implementations to prove
// consistency when the bug is fixed. Also fix documentation and perhaps
// merge tests: these tests currently also touch non-compact currency
// formatting.
import 'package:intl/intl.dart' as intl;
import 'package:js/js_util.dart' as js;
import 'package:test/test.dart';
Expand Down

0 comments on commit 32844f3

Please sign in to comment.