re-enable pana baseline checking (pending build fixes)

[pq]

See, for example: https://github.com/dart-lang/linter/pull/2502/checks?check_run_id=2087774664

Chatting with @jonasfj, this will require a bit of local debugging. (Just haven't gotten to it yet...)

[pq]

Interestingly, this runs w/o issues locally. 🤔

[pq]

[~/src/repos/linter] (master) $ dart tool/pana_baseline.dart
...
   {
    "id": "null-safety",
    "title": "Support sound null-safety",
    "grantedPoints": 0,
    "maxPoints": 0,
    "status": "passed",
    "summary": "### [*] 0/0 points: Package and dependencies are fully migrated to null-safety, and will be awarded additional points in a planned future revision of the pub.dev points model.\n"
   }
  ]
 },
 "scores": {
  "grantedPoints": 90,
  "maxPoints": 100
 }
}

{grantedPoints: 90, maxPoints: 100}
Baseline check passed ✅
... you have a new baseline! 🎉 Consider updating tool/baseline/pana.json to match.

[pq]

Here's the CI error:

{"logName":"pana","level":"INFO","message":"Running `/opt/hostedtoolcache/dart-sdk/bin/dartanalyzer --options /home/runner/work/linter/linter/pana_analysis_options_1615478856916256.g.yaml --format machine bin lib`..."}
{"level":"SHOUT","message":"Problem analyzing /home/runner/work/linter/linter","error":"Invalid argument(s): Provided content does not align with expectations.\n`No dart files found at: /home/runner/work/linter/linter/lib`","stackTrace":"#0      parseCodeProblem (package:pana/src/code_problem.dart:52:5)\n#1      PackageContext.staticAnalysis.<anonymous closure> (package:pana/src/package_context.dart:121:23)\n#2      MappedIterator.moveNext (dart:_internal/iterable.dart:390:20)\n#3      WhereIterator.moveNext (dart:_internal/iterable.dart:436:22)\n#4      SetMixin.addAll (dart:collection/set.dart:57:23)\n#5      new LinkedHashSet.of (dart:collection/linked_hash_set.dart:111:27)\n#6      Iterable.toSet (dart:core/iterable.dart:376:21)\n#7      PackageContext.staticAnalysis (package:pana/src/package_context.dart:123:12)\n<asynchronous suspension>\n#8      PackageAnalyzer._inspect (package:pana/src/package_analyzer.dart:145:25)\n<asynchronous suspension>\n#9      main (file:///home/runner/.pub-cache/hosted/pub.dartlang.org/pana-0.15.3/bin/pana.dart:163:19)\n<asynchronous suspension>\n"}

@jonasfj : any thoughts?

[jonasfj]

Are the sources located in /home/runner/work/linter/linter/lib or /home/runner/work/linter/lib ?

Maybe an extra linter folder was given?

Just a qualified guess from seeing:

Invalid argument(s): Provided content does not align with expectations.
No dart files found at: /home/runner/work/linter/linter/lib`"

[pq]

Right. The path is definitely wrong. Here's where it's set:

  var output = await Process.run('pub', [
    'global',
    'run',
    'pana',
    '-s',
    'path',
    Directory.current.path,
    '-j',
  ]);

This used to work? 🤔

[pq]

Disabled w/ #2518 pending some investigation.

[pq]

Running this again (locally), I'm seeing this error:

{"logName":"pana","level":"INFO","message":"Running `/Applications/Tools/dart-sdk/bin/dart --version`..."}
Unhandled exception:
Null check operator used on a null value
#0      new DartSdkInfo.parse (package:pana/src/sdk_env.dart:505:38)
#1      ToolEnvironment._init (package:pana/src/sdk_env.dart:87:37)
<asynchronous suspension>
#2      ToolEnvironment.create (package:pana/src/sdk_env.dart:160:5)
<asynchronous suspension>
#3      PackageAnalyzer.create (package:pana/src/package_analyzer.dart:60:28)
<asynchronous suspension>
#4      main (file:///Users/pquitslund/.pub-cache/hosted/pub.dartlang.org/pana-0.19.1/bin/pana.dart:134:22)
<asynchronous suspension>

It looks like maybe an issue parsing the Dart SDK version?

☁  linter [master] dart --version
Dart SDK version: 2.15.0-edge.e8ddc0219f1e8f1ad784143fec693890e2b81954 (be) (Fri Aug 13 13:27:41 2021 +0000) on "macos_x64"

Invocation details are here, for reference:

linter/tool/pana_baseline.dart

Lines 22 to 30 in ff202b2

	var output = await Process.run('pub', [
	'global',
	'run',
	'pana',
	'-s',
	'path',
	Directory.current.path,
	'-j',
	]);

/fyi @sigurdm @jonasfj