[analyzer] Type aliases are not working well with the always_specify_types rule

[AlexV525]

typedef JsonMap = Map<String, dynamic>;
typedef JsonList = List<JsonMap>;

This tracker is for issues related to: Analyzer

• Dart SDK Version: 2.13.1
• macOS BigSur

[AlexV525]

@srawlins Any priority on this? It's preventing us to use type alias since it raises warnings.

[srawlins]

@AlexV525 no priority on this yet.

@pq I'm not sure how we prioritize false positives...

[bwilkerson]

In my opinion, false positives should generally have a high priority because they erode user trust.

[AlexV525]

Another false positive about always_specify_types #2671 .

[pq]

+1 to what Brian said. As far as prioritizing relative to other false positives, I (informally) apply a multiplier for issues impacting core/recommended/pedantic/flutter lints. I'm looking at making this more formal FWIW... (And if anyone wants to brainstorm about that, let me know!)

[srawlins]

I think each false positive would get a priority bump also because they don't require cleanup, if the fix really means that no new cases would be reported.

[AlexV525]

And now it's the "New feature has come, but it's not really come" thing since we can't really put it into production... 😓 An issue for a new feature might have a priority bump too?

[srawlins]

Can you not // ignore the lint reported? I don't think this should block adoption of new type aliases.

[AlexV525]

We could, but we shouldn't. The profit that type aliases bring is less than the code quality drop's effects. Consider that we have multiple classes that would need to use Json alias, then we'll going to ignore it everywhere when we use it.

[AlexV525]

And after the brainstorm here this issue still don't have a priority which is still blocking us to migrate...