Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement implicit_reopen #3920

Closed
Tracked by #3917
pq opened this issue Dec 15, 2022 · 7 comments · Fixed by #4101
Closed
Tracked by #3917

implement implicit_reopen #3920

pq opened this issue Dec 15, 2022 · 7 comments · Fixed by #4101
Assignees
Labels
lint-proposal new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures status-accepted
Milestone

Comments

@pq
Copy link
Member

pq commented Dec 15, 2022

From the base-interface-final spec:

@reopen lint
...

A metadata annotation @reopen is added to package meta and a lint "require_reopen" implicit_reopen is added to the linter. When the lint is enabled, a lint warning is reported if a class or mixin is not annotated @reopen and it:

Extends or mixes in a class, mixin, or mixin class marked interface or final and is not itself marked interface or final.

@pq pq added lint-proposal new-language-feature P2 A bug or feature request we're likely to work on labels Dec 15, 2022
@pq pq added this to the Dart 3 beta 1 milestone Dec 15, 2022
@pq pq changed the title implement require_reopen implement implicit_reopen Jan 18, 2023
@pq
Copy link
Member Author

pq commented Jan 18, 2023

Updating the proposed name to implicit_reopen as per the conversation in https://dart-review.googlesource.com/c/sdk/+/278888.

/fyi @lrhn @bwilkerson

@pq
Copy link
Member Author

pq commented Feb 27, 2023

See also: dart-lang/language#2871

@pq pq mentioned this issue Mar 1, 2023
@srawlins
Copy link
Member

srawlins commented Mar 8, 2023

Is this ticket blocked?

@pq
Copy link
Member Author

pq commented Mar 8, 2023

Yes. I'm scrapping a prototype that duplicates the class modifier induction algorithm in analyzer in favor of a new implementation that will leverage @kallentu's work (underway) to thread that information through the element model (when it's complete).

@srawlins
Copy link
Member

srawlins commented Mar 8, 2023

Thanks, @kallentu is there a ticket for your work, or a CL?

@kallentu
Copy link
Member

kallentu commented Mar 8, 2023

@srawlins There isn't. Made a quick one here dart-lang/sdk#51671
CL is still WIP.

@srawlins
Copy link
Member

srawlins commented Mar 8, 2023

Thanks much!

@pq pq added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Mar 22, 2023
@pq pq closed this as completed in #4101 Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint-proposal new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures status-accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants