Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce sorting in tests/CI #4273

Closed
pq opened this issue Apr 12, 2023 · 2 comments
Closed

enforce sorting in tests/CI #4273

pq opened this issue Apr 12, 2023 · 2 comments
Assignees
@pq
Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-test

Comments

@pq
Copy link
Member

pq commented Apr 12, 2023

#4272 (review)

(We can crib this from how we do a similar check in analyzer.)
@pq pq added type-test area-build type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P2 A bug or feature request we're likely to work on labels Apr 12, 2023
@pq pq mentioned this issue Apr 12, 2023
Merged
@pq pq self-assigned this Apr 12, 2023
@pq
Copy link
Member Author

pq commented Apr 12, 2023

(We can crib this from how we do a similar check in analyzer.)

OK. I remember why I haven't done this yet. MemberSorter is in server...

@pq
Copy link
Member Author

pq commented Apr 12, 2023

Duplicate of #2368

@pq pq marked this as a duplicate of #2368 Apr 12, 2023
@pq pq closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq