From 296efaf2914af7c8c3268568ec4f23f3ff33f327 Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Thu, 28 Sep 2023 09:52:28 -0700 Subject: [PATCH] remove no_wildcard_variable_uses; improve testing (#156) * remove no_wildcard_variable_uses; improve testing * update workflow min. to 3.0 * fail-fast: false * fix workflow file --- .github/workflows/validate.yml | 6 ++++++ CHANGELOG.md | 5 ++++- lib/core.yaml | 1 - pubspec.yaml | 2 +- rules.md | 1 - 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml index be846d6..7a77889 100644 --- a/.github/workflows/validate.yml +++ b/.github/workflows/validate.yml @@ -14,10 +14,16 @@ on: jobs: build: runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + sdk: [3.0.0, stable, beta] steps: - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 - uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f + with: + sdk: ${{ matrix.sdk }} - run: dart pub get - run: dart format --output=none --set-exit-if-changed . diff --git a/CHANGELOG.md b/CHANGELOG.md index a10b1fd..f0388e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,9 +1,12 @@ +## 3.0.0-beta.2 + +- Remove `no_wildcard_variable_uses` from core. + ## 3.0.0-beta - `core`: - added `collection_methods_unrelated_type` - added `implicit_call_tearoffs` - - added `no_wildcard_variable_uses` - added `secure_pubspec_urls` - added `type_literal_in_constant_pattern` - added `use_string_in_part_of_directives` diff --git a/lib/core.yaml b/lib/core.yaml index 6bedf96..9f0e6e4 100644 --- a/lib/core.yaml +++ b/lib/core.yaml @@ -21,7 +21,6 @@ linter: - hash_and_equals - implicit_call_tearoffs - no_duplicate_case_values - - no_wildcard_variable_uses - non_constant_identifier_names - null_check_on_nullable_type_parameter - package_prefixed_library_names diff --git a/pubspec.yaml b/pubspec.yaml index 65ad7bc..b8df5e6 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,5 +1,5 @@ name: lints -version: 3.0.0-beta +version: 3.0.0-beta.2 description: > Official Dart lint rules. Defines the 'core' and 'recommended' set of lints suggested by the Dart team. diff --git a/rules.md b/rules.md index 06c3b3c..44a384f 100644 --- a/rules.md +++ b/rules.md @@ -20,7 +20,6 @@ | [`hash_and_equals`](https://dart.dev/lints/hash_and_equals) | Always override `hashCode` if overriding `==`. | ✅ | | [`implicit_call_tearoffs`](https://dart.dev/lints/implicit_call_tearoffs) | Explicitly tear-off `call` methods when using an object as a Function. | ✅ | | [`no_duplicate_case_values`](https://dart.dev/lints/no_duplicate_case_values) | Don't use more than one case with same value. | ✅ | -| [`no_wildcard_variable_uses`](https://dart.dev/lints/no_wildcard_variable_uses) | Don't use wildcard parameters or variables. | | | [`non_constant_identifier_names`](https://dart.dev/lints/non_constant_identifier_names) | Name non-constant identifiers using lowerCamelCase. | ✅ | | [`null_check_on_nullable_type_parameter`](https://dart.dev/lints/null_check_on_nullable_type_parameter) | Don't use null check on a potentially nullable type parameter. | ✅ | | [`package_prefixed_library_names`](https://dart.dev/lints/package_prefixed_library_names) | Prefix library names with the package name and a dot-separated path. | |