Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefer_equal_for_default_values from the recommended.yaml set #143

Closed
parlough opened this issue Aug 11, 2023 · 2 comments
Closed

Comments

@parlough
Copy link
Member

parlough commented Aug 11, 2023

Now that the package requires SDK ^3.0.0, this lint does nothing since it's not reported by the Dart 3 SDK, which instead reports the deprecated_colon_for_default_value diagnostic for 2.12-2.19 language versions.

\cc @pq @devoncarew

@lrhn
Copy link
Member

lrhn commented Sep 19, 2023

If we have made the SDK requirement for this package ^3.0.0, then the lint is definitely not needed.

If the same version of the lints package can be used by older SDKs, then it might be worth retaining, as long as we're sure that the lint doesn't cause double-reports in SDKs where the analyzer warns itself. (I guess that when the analyzer knows that it reports useing :, it can also know to ignore this lint.)

@devoncarew
Copy link
Member

Removal approved.

@devoncarew devoncarew moved this from Under consideration to Approved in Lints Triage Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants