Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: include change log in "Package uploaded" emails #2028

Open
amirh opened this issue Feb 8, 2019 · 5 comments
Open

Feature request: include change log in "Package uploaded" emails #2028

amirh opened this issue Feb 8, 2019 · 5 comments

Comments

@amirh
Copy link

amirh commented Feb 8, 2019

Would be nice if the "Package uploaded: " email that is sent to package uploaders will include the changelog, that's the main thing I care about when I see these emails.

Thanks!

@jonasfj
Copy link
Member

jonasfj commented Feb 11, 2019

Before we try this we should have a format enforcer for the changelog, maybe even reduce package score if older entries of the changelog were modified. This seems hard to do, and perhaps a bit extreme...

@amirh, why do you want this? These emails are sent to all uploaders, ie. people who are working on the package, not downstream consumers of the package. An important goal with this is make compromised credentials easier to detect.

I'm still not entirely sure we should do this... I think it's better to send the relevant changelog section to people who subscribe for updates... and then allowing you to subscribe for updated on your favorite packages, including packages you don't necessarily own.

@amirh
Copy link
Author

amirh commented Feb 11, 2019

We are doing some common maintenance for all the flutter/plugins packages.
Sometimes someone is doing some maintenance to all packages (e.g upgrading common dependencies).
When this happen and I get a "Package uploaded" email for a package I maintain I want to know what happened, last few times this happened I had to go to pub and check the change log.
Not a super big deal but I assumed it should be easy to append the changelog to the email (even the entire changelog, or top N lines are good for me) and can help answer the "what was just pushed" question faster.

@isoos isoos added this to the On Deck milestone Feb 11, 2019
@jonasfj
Copy link
Member

jonasfj commented Feb 12, 2019

It'll answer "what was just pushed" if you trust the uploader and is confident the uploader wasn't compromised.

@kevmoo
Copy link
Member

kevmoo commented Oct 30, 2020

50% of the upload emails I get from other folks – I click the link and open the changelog to see the delta.

This would be "very nice".

@sigurdm
Copy link
Contributor

sigurdm commented Oct 31, 2024

This is still attractive to do.

Relates to dart-lang/pana#1406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants