-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The output of dart pub outdated --mode=null-safety
is pretty confusing for a package that's already ...ready
#2745
Comments
I want to work on this issue and @kevmoo can you guide me on what output needs to be shown in this case and some relevant help. |
I think the main change is that: I think saying 'congrats' would be promising too much. Depending on the parameters to |
@sigurdm looks like the issue are resolved now! |
I don't think so - I still see this with 2.12.0 stable. |
This is the response I am getting in dart 2.12.0 stable is $ dart pub outdated --mode=null-safety
Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.
Package Name Current Upgradable Resolvable Latest
direct dependencies: all support null safety.
dev_dependencies: all support null safety.
You are already using the newest resolvable versions listed in the 'Resolvable' column.
Newer versions, listed in 'Latest', may not be mutually compatible.
Are we supposed to remove the last 2 lines in this response. I would like to work to it. |
Yes - the two last lines are confusing. When there are no rows they should not be shown. Perhaps another message saying something like 'All dependencies opt in to null-safety.' That would be a nice contribution! |
I have updated the code accordingly, and now I am getting the following output: Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.
Package Name Current Upgradable Resolvable Latest
direct dependencies: all support null safety.
dev_dependencies: all support null safety.
All dependencies opt in to null-safety.
Is this what we wanted? |
Yes that looks pretty good. |
I ran the tool (Dart SDK version: 2.12.0-29.0.dev) over
pkg:convert
at dart-archive/convert@561d73bThere's clearly a bunch of stuff here assuming a table is being displayed – when there's no table!
Maybe we should just say
Congrats! 👍
?The text was updated successfully, but these errors were encountered: