Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The output of dart pub outdated --mode=null-safety is pretty confusing for a package that's already ...ready #2745

Closed
kevmoo opened this issue Nov 11, 2020 · 8 comments · Fixed by #2898

Comments

@kevmoo
Copy link
Member

kevmoo commented Nov 11, 2020

I ran the tool (Dart SDK version: 2.12.0-29.0.dev) over pkg:convert at dart-archive/convert@561d73b

Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.

Package Name  Current  Upgradable  Resolvable  Latest

direct dependencies: all support null safety.

dev_dependencies: all support null safety.

Current dependencies are constrained to versions listed in Resolvable.
A resolution compatible with the Latest versions doesn't exist, as they are not
mutually compatible.

There's clearly a bunch of stuff here assuming a table is being displayed – when there's no table!

Maybe we should just say Congrats! 👍 ?

@azadprajapat
Copy link
Contributor

I want to work on this issue and @kevmoo can you guide me on what output needs to be shown in this case and some relevant help.

@sigurdm
Copy link
Contributor

sigurdm commented Jan 18, 2021

I think the main change is that: Current dependencies are constrained to versions listed in Resolvable. Should not be shown if we don't show any packages in the resolvable column. And A resolution compatible with the Latest versions doesn't exist, as they are not mutually compatible. Should not be shown when there is no packages in the latest column.

I think saying 'congrats' would be promising too much. Depending on the parameters to dart pub outdated there might still be packages to upgrade.

@tusharojha
Copy link
Contributor

@sigurdm looks like the issue are resolved now!

@sigurdm
Copy link
Contributor

sigurdm commented Mar 4, 2021

I don't think so - I still see this with 2.12.0 stable.

@tusharojha
Copy link
Contributor

This is the response I am getting in dart 2.12.0 stable is

$ dart pub outdated --mode=null-safety
Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.

Package Name  Current  Upgradable  Resolvable  Latest

direct dependencies: all support null safety.

dev_dependencies: all support null safety.
You are already using the newest resolvable versions listed in the 'Resolvable' column.
Newer versions, listed in 'Latest', may not be mutually compatible.

Are we supposed to remove the last 2 lines in this response. I would like to work to it.

@sigurdm
Copy link
Contributor

sigurdm commented Mar 4, 2021

Yes - the two last lines are confusing. When there are no rows they should not be shown. Perhaps another message saying something like 'All dependencies opt in to null-safety.'

That would be a nice contribution!

@tusharojha
Copy link
Contributor

I have updated the code accordingly, and now I am getting the following output:

Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.

Package Name  Current  Upgradable  Resolvable  Latest

direct dependencies: all support null safety.

dev_dependencies: all support null safety.
All dependencies opt in to null-safety.

Is this what we wanted?

@sigurdm
Copy link
Contributor

sigurdm commented Mar 5, 2021

Yes that looks pretty good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants