Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globs support for defining packages in workspaces #4391

Open
spydon opened this issue Sep 18, 2024 · 3 comments
Open

Globs support for defining packages in workspaces #4391

spydon opened this issue Sep 18, 2024 · 3 comments
Labels
type-enhancement A request for a change that isn't a bug

Comments

@spydon
Copy link

spydon commented Sep 18, 2024

I think this is already planned, but I'm opening an issue so that it can be tracked.

Adding globs support will:

  • reduce a lot of user mistakes (like forgetting to add new packages to the workspace)
  • make migrations from the current melos version to the future melos version where packages are instead defined in the workspace much easier, since their current definitions could just be moved from melos.yaml to the workspace config file

Design doc discussion: https://docs.google.com/document/d/1UEEAGdWIgVf0X7o8WPQCPmL4LSzaGCfJTM0pURoDLfE/edit?resourcekey=0-c5CMaOoc_pg3ZwJKMAM0og&disco=AAAA9uS5yhA

@jonasfj jonasfj added the type-enhancement A request for a change that isn't a bug label Sep 24, 2024
@jonasfj
Copy link
Member

jonasfj commented Sep 24, 2024

I think add globs in workspace: might be nice, but perhaps it is a follow up enhancement. While it does seem feasible, it definitely will involve some work making sure we can still efficiently validate package_config.json using timestamps.

At-least I don't want it to block launching 🚀

@spydon
Copy link
Author

spydon commented Sep 24, 2024

At-least I don't want it to block launching 🚀

Makes sense, I think we'll wait with putting up a migration from Melos to Melos + workspaces until this is done then. Because it will be quite a painful experience for all projects with more than a few packages.

@sigurdm
Copy link
Contributor

sigurdm commented Sep 24, 2024

Yeah - I don't think this will make it for 3.6 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants