Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equality of Sets should be fixed. #10391

Closed
efortuna opened this issue May 2, 2013 · 2 comments
Closed

Equality of Sets should be fixed. #10391

efortuna opened this issue May 2, 2013 · 2 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@efortuna
Copy link
Contributor

efortuna commented May 2, 2013

With the following code:

  var a = new Set.from(['emily', 'm', 'fortuna']);
  var b = new Set.from(['emily', 'm', 'fortuna']);
  print(a == b);

"false" gets printed.

These are both Hash sets whose containing objects implement equality based on content, so we should actually inspect the hash set contents to see if the elements in the set are the same and return true, rather than just checking if a and b are the same Set object.

@lrhn
Copy link
Member

lrhn commented May 3, 2013

Removed Type-Defect label.
Added Type-Enhancement, Duplicate labels.
Marked as being merged into #2217.

@floitschG
Copy link
Contributor

Issue #14638 has been merged into this issue.

@efortuna efortuna added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report labels Oct 31, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants