Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update polymer-build to match new 'main' semantics #14797

Closed
sigmundch opened this issue Nov 4, 2013 · 3 comments
Closed

update polymer-build to match new 'main' semantics #14797

sigmundch opened this issue Nov 4, 2013 · 3 comments
Assignees
@sigmundch
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
M8

Comments

@sigmundch
Copy link
Member

the spec changed recently (see issue #14541).

The new semantics imply that we should no longer inject a main wrapper (see polymerMainWrapper in script_compactor.dart). Instead, we should just call main on the original code.

This change should be done together with the changes in the Dartium and dart2js.
@sigmundch
Copy link
Member Author

https://codereview.chromium.org/57423005/

@sigmundch
Copy link
Member Author

Fix is pending in dartium (see issue #14803), I plan to submit immediately after that comes in.

This was already fixed in dart2js (see issue #14762)

Marked this as being blocked by #14803.

@sigmundch
Copy link
Member Author

Fixed in r29870

Added Fixed label.

@sigmundch sigmundch added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Nov 5, 2013
@sigmundch sigmundch self-assigned this Nov 5, 2013
@sigmundch sigmundch added this to the M8 milestone Nov 5, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmundch sigmundch

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
M8
Development

No branches or pull requests
1 participant
@sigmundch