-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify DDC SDK with Dart repo's SDK #27314
Comments
From @munificent on May 4, 2016 21:14 I'll take dart:async. |
From @munificent on May 5, 2016 22:4 dart:async is done as of 8154650779ea579e4d599ad422e459305b405eac |
From @munificent on May 6, 2016 0:10 Working on Uri and probably dart:convert (since Uri uses it) now. |
From @rakudrama on May 6, 2016 20:12 Blocked by #253: |
From @munificent on May 11, 2016 0:26 OK, Uri and dart:convert are landed, though @floitschG says there may be some more dart:convert changes coming soon after. What's left to do? |
From @munificent on May 11, 2016 23:51 This issue was originally about unforking DDC's SDK but we've been using it to refer to rolling it. To disambiguate, I'm forking the bug. This one is now about unforking. The bug for just rolling the latest SDK is #565. |
I investigated DDC summary. We can produce it with new Analyzers, but we can't build tests against it because some packages and a few tests seem to depend on dart:io (not sure if they use much of it or what's up there). |
this should be way easier nowadays because we're in the same repo |
here's one SDK fix: https://codereview.chromium.org/2718643003/ |
okay current list of problems. Bob's CL here needs to be redone 20e402c lots of typing problems with dart:convert, in particular "startChunkedConversion" and "bind" need to copy over a workaround for unsound typing in ListMixin.sort (we already have this workaround in JSArray.sort) copied over some more things from dart2js impl code (this will be in my CL) |
another SDK fix https://codereview.chromium.org/2715833004/ |
fixed with fe294f3 ... I'll open a new one for tracking the html libraries |
new issue #28929 |
🎉🎉🎉🎉🎉 |
DDC compiles against the Dart SDK that is installed, but runs against an older built snapshot from our implementation. Now that we're in the same repository, we should be able to handle this in the patch_sdk script.
The text was updated successfully, but these errors were encountered: