Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify DDC SDK with Dart repo's SDK #27314

Closed
jmesserly opened this issue Sep 13, 2016 · 16 comments
Closed

Unify DDC SDK with Dart repo's SDK #27314

jmesserly opened this issue Sep 13, 2016 · 16 comments
Assignees
Labels
dev-compiler-sdk P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler

Comments

@jmesserly
Copy link

jmesserly commented Sep 13, 2016

DDC compiles against the Dart SDK that is installed, but runs against an older built snapshot from our implementation. Now that we're in the same repository, we should be able to handle this in the patch_sdk script.

@jmesserly
Copy link
Author

From @munificent on May 4, 2016 21:14

I'll take dart:async.

@jmesserly
Copy link
Author

From @vsmenon on May 5, 2016 19:17

@jacob314 will look at dart:html once dart:async is landed

@jmesserly
Copy link
Author

From @munificent on May 5, 2016 22:4

dart:async is done as of 8154650779ea579e4d599ad422e459305b405eac

@jmesserly
Copy link
Author

From @munificent on May 6, 2016 0:10

Working on Uri and probably dart:convert (since Uri uses it) now.

@jmesserly
Copy link
Author

From @rakudrama on May 6, 2016 20:12

Blocked by #253:
lib/collection/linked_list.dart
lib/collection/queue.dart
lib/collection/splay_map.dart

@jmesserly
Copy link
Author

From @munificent on May 11, 2016 0:26

OK, Uri and dart:convert are landed, though @floitschG says there may be some more dart:convert changes coming soon after. What's left to do?

@jmesserly
Copy link
Author

From @munificent on May 11, 2016 23:51

This issue was originally about unforking DDC's SDK but we've been using it to refer to rolling it. To disambiguate, I'm forking the bug. This one is now about unforking. The bug for just rolling the latest SDK is #565.

@jmesserly
Copy link
Author

I investigated DDC summary. We can produce it with new Analyzers, but we can't build tests against it because some packages and a few tests seem to depend on dart:io (not sure if they use much of it or what's up there).

@jmesserly
Copy link
Author

this should be way easier nowadays because we're in the same repo

@jmesserly
Copy link
Author

@jmesserly jmesserly self-assigned this Feb 17, 2017
@jmesserly jmesserly added P2 A bug or feature request we're likely to work on P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Feb 17, 2017
@jmesserly
Copy link
Author

here's one SDK fix: https://codereview.chromium.org/2718643003/

@jmesserly
Copy link
Author

okay current list of problems.

Bob's CL here needs to be redone 20e402c

lots of typing problems with dart:convert, in particular "startChunkedConversion" and "bind"

need to copy over a workaround for unsound typing in ListMixin.sort (we already have this workaround in JSArray.sort)

copied over some more things from dart2js impl code (this will be in my CL)

@jmesserly
Copy link
Author

another SDK fix https://codereview.chromium.org/2715833004/

@jmesserly
Copy link
Author

fixed with fe294f3 ... I'll open a new one for tracking the html libraries

@jmesserly
Copy link
Author

new issue #28929

@munificent
Copy link
Member

🎉🎉🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-compiler-sdk P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Development

No branches or pull requests

2 participants