We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have some code like this (dart:html imported with html prefix):
var selection = html.window.getSelection(); var range = selection.getRangeAt(0); var rects = range.getClientRects(); if (rects.length < 1) { ... }
During a code review, my reviewer said I should just use rects.isEmpty(). However, rects is a ClientRectList which is not a subtype of List.
I wonder if it would be possible to get rid of the class ClientRectList completely and just use a List<ClientRect> instead?
The text was updated successfully, but these errors were encountered:
This comment was originally written by @seaneagan
this should be merged into issue #2713
Sorry, something went wrong.
Thank you, Sean!
Added Duplicate label. Marked as being merged into #2713.
No branches or pull requests
I have some code like this (dart:html imported with html prefix):
var selection = html.window.getSelection();
var range = selection.getRangeAt(0);
var rects = range.getClientRects();
if (rects.length < 1) {
...
}
During a code review, my reviewer said I should just use rects.isEmpty(). However, rects is a ClientRectList which is not a subtype of List.
I wonder if it would be possible to get rid of the class ClientRectList completely and just use a List<ClientRect> instead?
The text was updated successfully, but these errors were encountered: