Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientRectList should be a List #2972

Closed
peter-ahe-google opened this issue May 9, 2012 · 2 comments
Closed

ClientRectList should be a List #2972

peter-ahe-google opened this issue May 9, 2012 · 2 comments
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug

Comments

@peter-ahe-google
Copy link
Contributor

I have some code like this (dart:html imported with html prefix):

    var selection = html.window.getSelection();
    var range = selection.getRangeAt(0);
    var rects = range.getClientRects();
    if (rects.length < 1) {
      ...
    }

During a code review, my reviewer said I should just use rects.isEmpty(). However, rects is a ClientRectList which is not a subtype of List.

I wonder if it would be possible to get rid of the class ClientRectList completely and just use a List<ClientRect> instead?

@DartBot
Copy link

DartBot commented May 9, 2012

This comment was originally written by @seaneagan


this should be merged into issue #2713

@peter-ahe-google
Copy link
Contributor Author

Thank you, Sean!


Added Duplicate label.
Marked as being merged into #2713.

@peter-ahe-google peter-ahe-google added Type-Enhancement closed-duplicate Closed in favor of an existing report labels May 9, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants