Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dart:isolate and tests to NNBD #40042

Closed
leafpetersen opened this issue Jan 9, 2020 · 7 comments
Closed

Migrate dart:isolate and tests to NNBD #40042

leafpetersen opened this issue Jan 9, 2020 · 7 comments
Assignees
@a-siva
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Milestone
D28 Release

Comments

@leafpetersen
Copy link
Member

Sub issue of #38037 .
@leafpetersen leafpetersen added NNBD Issues related to NNBD Release area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Jan 9, 2020
@leafpetersen
Copy link
Member Author

Migration instructions here.

@a-siva a-siva added the vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked label Jan 16, 2020
@a-siva a-siva mentioned this issue Jan 16, 2020
Closed
@franklinyow franklinyow added this to the D28 Release milestone Jan 21, 2020
@a-siva
Copy link
Contributor

a-siva commented Feb 12, 2020

The library has been ported, port of the isolate specific tests are in progress.

@franklinyow
Copy link
Contributor

Any update on this? Thx!

@leafpetersen leafpetersen mentioned this issue Mar 2, 2020
Closed
@franklinyow
Copy link
Contributor

Ping

@mit-mit
Copy link
Member

mit-mit commented Mar 19, 2020

cc @a-siva for status update

@a-siva
Copy link
Contributor

a-siva commented Mar 19, 2020 •
edited
Loading

The first part of this which is migrating the isolate tests away from the unittest package
landed yesterday https://dart-review.googlesource.com/c/sdk/+/139953.

The second part which migrated a large number of tests is being reviewed here
https://dart-review.googlesource.com/c/sdk/+/139980

After that lands we will have another CL today which moves the rest of the tests.

@a-siva
Copy link
Contributor

a-siva commented Mar 20, 2020

With https://dart-review.googlesource.com/c/sdk/+/140162 the remaining isolate tests have been migrated.
tests/lib_2/isolate/isolate_stress_test.dart was not used by the VM and was probably an old dart2js
test. This file was not migrated.

@a-siva a-siva closed this as completed Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-siva a-siva

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. NNBD Issues related to NNBD Release vm-nnbd-unfork-sdk Label for all issues that need to be done before the nnbd sdk can be unforked
Projects
None yet
Milestone
D28 Release
Development

No branches or pull requests
4 participants
@leafpetersen @a-siva @mit-mit @franklinyow