Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected RuntimeError or Failures when running co19/languageFeatures/nnbd tests #41732

Closed
a-siva opened this issue Apr 30, 2020 · 7 comments
Closed

Unexpected RuntimeError or Failures when running co19/languageFeatures/nnbd tests #41732

a-siva opened this issue Apr 30, 2020 · 7 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@a-siva
Copy link
Contributor

a-siva commented Apr 30, 2020

Unexpected RuntimeError or Failures when running co19/languageFeatures/nnbd tests in weak/strong NNBD modes.

dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t64 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t65 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t66 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/generics_A01_t07 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t03 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t07 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t13 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t17 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t23 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t27 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t33 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t37 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t010 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t011 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t042 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t064 is new and failed (RuntimeError, expected Pass)
dartk-strong-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t068 is new and failed (RuntimeError, expected Pass)dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t11 is new and failed (Fail, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t39 is new and failed (Fail, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t73 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/future_flattening_A01_t74 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/list_length_t02 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t03 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t07 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t13 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t17 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t23 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t27 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t33 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t37 is new and failed (RuntimeError, expected Pass)dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t012 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t026 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t029 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t043 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t047 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t052 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t054 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t071 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t072 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t085 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t100 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t115 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t121 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t122 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t124 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t130 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t147 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t148 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t154 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t156 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t159 is new and failed (RuntimeError, expected Pass)
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/type_reification_A01_t03 is new and failed (RuntimeError, expected Pass)
@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Apr 30, 2020
@a-siva
Copy link
Contributor Author

a-siva commented Apr 30, 2020

/cc @crelier @liamappelbe @alexmarkov

@crelier
Copy link
Contributor

crelier commented Apr 30, 2020 •
edited
Loading

So far, I filed co19 issues for strong mode failures at runtime:

dart-lang/co19#627
co19/LanguageFeatures/nnbd/future_flattening_A01_t64
co19/LanguageFeatures/nnbd/future_flattening_A01_t65
co19/LanguageFeatures/nnbd/future_flattening_A01_t66

dart-lang/co19#620
co19/LanguageFeatures/nnbd/list_length_t03

dart-lang/co19#622
co19/LanguageFeatures/nnbd/generics_A01_t07

dart-lang/co19#621
co19/LanguageFeatures/nnbd/late_A07_t01
co19/LanguageFeatures/nnbd/late_A07_t02

dart-lang/co19#624
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t03
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t07
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t13
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t17
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t23
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t27
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t33
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t37

dart-lang/co19#623
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t010
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t011
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t042
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t064
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t068

Most of the co19 issues have already been closed, but no rolled.

@alexmarkov
Copy link
Contributor

Filed dart-lang/co19#630 for
dartk-weak-asserts-linux-release-x64:co19/LanguageFeatures/nnbd/type_reification_A01_t03 failure.

@crelier
Copy link
Contributor

crelier commented Apr 30, 2020

Here are the remaining weak mode failures at runtime:

dart-lang/co19#628
co19/LanguageFeatures/nnbd/exports_A01_typedef1_t04

dart-lang/co19#629
co19/LanguageFeatures/nnbd/list_length_t02

dart-lang/co19#624
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t03
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t07
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t13
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t17
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t23
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t27
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t33
co19/LanguageFeatures/nnbd/overriding/override_checking_A01_CLASSPARAM_t37

dart-lang/co19#631
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t012
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t026
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t029
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t043
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t047
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t052
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t054
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t071
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t072
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t085
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t100
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t115
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t121
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t122
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t124
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t130
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t147
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t148
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t154
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t156
co19/LanguageFeatures/nnbd/overriding/override_checking_A06_t159

@crelier
Copy link
Contributor

crelier commented May 12, 2020

dart-lang/co19#641
co19/LanguageFeatures/nnbd/future_flattening_A01_t11
co19/LanguageFeatures/nnbd/future_flattening_A01_t39
co19/LanguageFeatures/nnbd/future_flattening_A01_t73
co19/LanguageFeatures/nnbd/future_flattening_A01_t74

@leafpetersen
Copy link
Member

What's the status on this?

@franklinyow franklinyow added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Sep 3, 2020
@alexmarkov
Copy link
Contributor

These tests are no longer failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@leafpetersen @crelier @a-siva @alexmarkov @franklinyow