Code Completion should put compatible data types at the top of the list in parameters

[petro-i]

This tracker is for issues related to:
Analysis server version: 1.28.0
Dart SDK: 2.10.0-11.0.dev (dev) (Tue Aug 11 02:21:48 2020 -0700) on "windows_x64"

There is no reason to show all possible options in the list above, the correct one is not even shown, the suggestion compatible by data type should come at the top of list. I don't know if there is any reason to keep all not compatible data types in the list (you could filter them in addition), but the compatible should be at the top and selected by default.

[devoncarew]

Thanks for the feedback!

I agree that we could improve the ordering here - generally, you'd want the most relevant items closest to the top.

There are a few reasons why you'd want to show non-compatible types in the list. One reason is that people don't just use completion to save characters, they also use it for discovery (what fields / methods does this object support?). The other is that the compatible type for the left hand side might be available off a field or method return type from the initial expression you're completing. In the example above, the class Colors isn't a valid type for the named param colors:, however something like Colors.white would be.

[morrica]

@devoncarew

In the example above, the class Colors isn't a valid type for the named param colors:, however something like Colors.white would be.

If that is the case, then when I type 'C' show Colors.white and omit Colors!

I do a lot of Dart and Java dev in Intellij. I love the Dart language, but going back and forth between the two really shows how terrible Dart auto-completion is. No other word for it. Just terrible. Maybe worse than no auto-complete at all. In my opinion, this is the biggest issue with Dart right now.</rant>

<praise>Regardless of the above, thanks for all the work you guys put into making it better.

[scheglov]

I also expected to see Color.xyz here.
But I don't get it, and I have no explanation why resolveWith that does not return Color at all, is the first.

Or maybe theme.xyz is there is ThemeData theme = Theme.of(context).

This is another issue that requires experimenting with relevances.