Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestAnimationFrame not passing timestamp in IE #4593

Closed
DartBot opened this issue Aug 19, 2012 · 2 comments
Closed

RequestAnimationFrame not passing timestamp in IE #4593

DartBot opened this issue Aug 19, 2012 · 2 comments
Labels
closed-duplicate Closed in favor of an existing report web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Aug 19, 2012

This issue was originally filed by [email protected]


dart2js:

When the browser (like IE) does not support window.requestAnimationFrame, window.setTimeout() is used, to simulate the same result:

this.requestAnimationFrame = function(callback) {
       return window.setTimeout(callback, 16 /* 16ms ~= 60fps */);
   };

But this will not pass the timestamp.

However the dart api states that the callback passes an integer with the timestamp:
typedef bool RequestAnimationFrameCallback(int time);

This will result in a crash when you start doing things like "b = time - a" because time is undefined.

It's easy to find a workaround but a better solution would be to make sure the parameter time != null.

@sethladd
Copy link
Contributor

Added Area-HTML, Triaged labels.

@vsmenon
Copy link
Member

vsmenon commented Aug 21, 2012

Added Duplicate label.
Marked as being merged into #3016.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

3 participants