Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart2js fails to resolve optional functional parameter with default value. #4597

Closed
lrhn opened this issue Aug 20, 2012 · 18 comments
Closed
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone

Comments

@lrhn
Copy link
Member

lrhn commented Aug 20, 2012

Example:
 foo(x, y, [int z(a,b) = bar]) => z(x,y);
reports:

funcarg.dart:3:12: Internal error: expected optional parameters
foo(x, y, [int z(a,b) = bar]) => z(x,y);
           ^^^^^^^^^^^^^^^^^

The error is triggered in resolver.dart line 2242:

­5 SignatureResolver.analyzeNodes (file:///.../dart/lib/compiler/implementation/resolver.dart:2242:24)

(Dart2js still don't support functions as compile time constants, but this error seems unrelated to that).

@peter-ahe-google
Copy link
Contributor

This is one of the things I'm willing to let slip, but please raise the priority if you disagree.


Added this to the M1 milestone.
Removed Priority-Medium label.
Added Priority-Low label.

@kasperl
Copy link

kasperl commented Sep 7, 2012

Changed the title to: "Dart2js fails to resolve optional functional parameter with default value.".

@floitschG
Copy link
Contributor

Issue #5026 has been merged into this issue.

@kasperl
Copy link

kasperl commented Oct 8, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@alan-knight
Copy link
Contributor

I ran into this today. I wouldn't suggest trying to squeeze it into M1 at this point, but calling it "Low" doesn't seem right.

@kasperl
Copy link

kasperl commented Oct 10, 2012

Removed Priority-Low label.
Added Priority-Medium label.

@lrhn
Copy link
Member Author

lrhn commented Oct 15, 2012

Marked this as blocking #5870.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Removed this from the M2 milestone.

@kasperl
Copy link

kasperl commented Oct 17, 2012

Added this to the M2 milestone.

@peter-ahe-google
Copy link
Contributor

Set owner to @peter-ahe-google.

@anders-sandholm
Copy link
Contributor

Confirmed/reproduced in Dart SDK version 0.2.2.1_r14458

@peter-ahe-google
Copy link
Contributor

Issue #6729 has been merged into this issue.

@peter-ahe-google
Copy link
Contributor

Bumping priority: this is the issue I have with most stars.


Removed Priority-Medium label.
Added Priority-High label.

@peter-ahe-google
Copy link
Contributor

Removed this from the M2 milestone.
Added this to the M3 milestone.

@kasperl
Copy link

kasperl commented Feb 4, 2013

Johnni, if you've got a few cycles maybe you can help Peter with this?


cc @johnniwinther.

@peter-ahe-google
Copy link
Contributor

Removed this from the M3 milestone.
Added this to the M4 milestone.

@peter-ahe-google
Copy link
Contributor

Set owner to [email protected].
Added Started label.

@DartBot
Copy link

DartBot commented Mar 12, 2013

This comment was originally written by @aam


Fixed in r19849.


Added Fixed label.

@lrhn lrhn added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Mar 12, 2013
@lrhn lrhn added this to the M4 milestone Mar 12, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

7 participants