Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ValidateStackFrameIteration fails when running with --optimization-counter-threshold=5 #4606

Closed
fsc8000 opened this issue Aug 20, 2012 · 4 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@fsc8000
Copy link
Contributor

fsc8000 commented Aug 20, 2012

Could this have to do with stack maps?

I'm running r10970:

Command line: out/ReleaseX64/run_vm_tests ValidateStackFrameIteration --ignore-unrecognized-flags --optimization-counter-threshold=5

Running test: ValidateStackFrameIteration
Done: ValidateStackFrameIteration

stderr:
../runtime/vm/stack_frame_test.cc:100: error: expected: code.raw() == function.unoptimized_code()
../runtime/vm/stack_frame_test.cc:100: error: expected: code.raw() == function.unoptimized_code()

@ghost
Copy link

ghost commented Aug 20, 2012

Added Area-VM, Triaged labels.

@ghost
Copy link

ghost commented Aug 20, 2012

This is a case of bad EXPECT. The test is surprised that the code already got optimized.


Set owner to @sgmitrovic.

@ghost
Copy link

ghost commented Aug 20, 2012

FIxed in r10993

@ghost
Copy link

ghost commented Aug 20, 2012

Added Fixed label.

@fsc8000 fsc8000 added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Aug 20, 2012
@fsc8000 fsc8000 assigned ghost Aug 20, 2012
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

1 participant