Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP][stable channel] Merge a3767f7db86a85fcd6201e9357ad47b884002b66 to stable channel (2.13) #46173

Closed
a-siva opened this issue May 28, 2021 · 7 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@a-siva
Copy link
Contributor

a-siva commented May 28, 2021

commit(s) to merge: a3767f7

merge instructions: clean merge

What is the issue: Flutter AOT precompiler crashes (flutter/flutter#83094)

What is the fix: Generate non-speculative Unbox instructions for Phis

Why cherrypick: This crash was reported by a Flutter user and it is possible other Flutter users may also run into this crash. When such a crash is reported it is not obvious the crash is because of this issue and we would spend additional engineering cycles investigating the crash and narrow it down to this cause.

Risk: The change has landed in master and is in the process of being rolled into Flutter. We should wait for it to be rolled fully which I hope will happen over the weekend.

Link to original issue(s): flutter/flutter#83094

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @alexmarkov

@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. merge-to-stable cherry-pick-review Issue that need cherry pick triage to approve labels May 28, 2021
@franklinyow
Copy link
Contributor

CC @kf6gpe

@franklinyow
Copy link
Contributor

@alexmarkov @mraleph
The original issue flutter/flutter#83094 is still open.
Can you give an update on the roll progress?

@kf6gpe
Copy link

kf6gpe commented Jun 1, 2021

I don't think this made the last cherrypick window. @christopherfujino can you confirm?

If not, let's keep this in mind for the next hotfix release. There's not one scheduled, but I could see taking this if we get enough to proceed.

@franklinyow
Copy link
Contributor

@kf6gpe We have not approved this pick. So this won't be in the last cherrypick window.

@kf6gpe
Copy link

kf6gpe commented Jun 2, 2021

Got it. I'll wait until it's approved and then add it to the list. Thanks!

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Jun 3, 2021
@franklinyow
Copy link
Contributor

Description:
Fix an crashing issue in Flutter precompiler , see flutter/flutter#83094 for detail

@athomas
Copy link
Member

athomas commented Jun 9, 2021

Merged to stable in 516eb3b (2.13.3).

@athomas athomas closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Development

No branches or pull requests

4 participants