co19 roll Patterns tests failing

[dcharkes]

There are new test failures on [dart2js] Migrate ssa/jump_handler.dart to null safety....[dart2wasm] Put types of exported functions in singleton rec groups.

The two commits in this range which introduced these new tests

• 0c87c84
• 036faf5

The tests

co19/LanguageFeatures/Patterns/list_A01_t01 Crash (expected Pass)
co19/LanguageFeatures/Patterns/map_A01_t01 Crash (expected Pass)
co19/LanguageFeatures/Patterns/object_A01_t02 Crash (expected Pass)
co19/LanguageFeatures/Patterns/object_A01_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Patterns/object_A01_t03 Crash (expected Pass)
co19/LanguageFeatures/Patterns/object_A01_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/Patterns/object_A02_t05 Crash (expected Pass)
co19/LanguageFeatures/Patterns/object_A02_t06 Crash (expected Pass)
co19/LanguageFeatures/Patterns/object_A04_t01 Crash (expected Pass)

are failing on configurations

cfe-strong-mac
cfe-strong-win
cfe-weak-mac
cfe-weak-win
dartdevc-canary-strong-linux-release-chrome-x64
dartdevc-canary-weak-linux-release-chrome-x64
dartk-strong-linux-debug-ia32
dartk-strong-linux-debug-simriscv64
dartk-strong-linux-release-ia32
dartk-strong-linux-release-simarm
dartk-strong-linux-release-simarm64
dartk-strong-mac-debug-arm64
dartk-strong-mac-debug-x64
dartk-strong-mac-release-x64
dartk-strong-win-debug-x64
dartk-strong-win-release-ia32
dartk-strong-win-release-x64
dartk-weak-asserts-linux-debug-ia32
dartk-weak-asserts-linux-debug-simriscv64
dartk-weak-asserts-linux-release-ia32
dartk-weak-asserts-linux-release-simarm
dartk-weak-asserts-linux-release-simarm64
dartk-weak-asserts-mac-debug-arm64
dartk-weak-asserts-mac-debug-x64
dartk-weak-asserts-mac-release-x64
dartk-weak-asserts-win-debug-x64
dartk-weak-asserts-win-release-ia32
dartk-weak-asserts-win-release-x64
dartkp-strong-linux-debug-simriscv64
dartkp-strong-linux-debug-x64
dartkp-strong-linux-release-simarm64
dartkp-strong-mac-release-simarm64
dartkp-strong-win-release-x64
dartkp-weak-asserts-linux-debug-simriscv64
dartkp-weak-asserts-linux-debug-x64
dartkp-weak-asserts-linux-release-simarm64
dartkp-weak-asserts-mac-release-simarm64
dartkp-weak-asserts-win-release-x64

cc @eernstg to triage if failures are expected.

If failures are not being tracked yet due to implementation being in flux please close this issue in favor of:

• [patterns] Implement the patterns feature. #50585

[eernstg]

Crashes are never expected, so we'd need to take another look at these ones:

co19/LanguageFeatures/Patterns/object_A01_t02 RuntimeError (expected Pass)
co19/LanguageFeatures/Patterns/object_A01_t03 RuntimeError (expected Pass)

co19/LanguageFeatures/Patterns/object_A01_t02 has been fixed in dart-lang/co19#1641, I would expect that change to solve the issue (when it's rolled in). co19/LanguageFeatures/Patterns/object_A01_t03 was changed similarly in the same PR.

That would turn this issue into a report about crashes, so I'll remove myself as the assignee.