Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix VM crash due to incorrect flowgraph float representation (JIT/debug configurations) #51147

Closed
aam opened this issue Jan 27, 2023 · 9 comments
Closed

[CP] Fix VM crash due to incorrect flowgraph float representation (JIT/debug configurations) #51147

aam opened this issue Jan 27, 2023 · 9 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@aam
Copy link
Contributor

aam commented Jan 27, 2023

Commit(s) to merge

ff2d661

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/279917

Issue Description

Mixed use of double and float calculation could cause to VM crash in debug/jit configuration.

What is the fix

The fix ensures correct (float) representation for phi-instructions, fixing the crash.

Why cherry-pick

Flutter and dart users are affected by the crash

Risk

medium

Issue link(s)

flutter/flutter#118559, #50622

Extra Info

No response
@aam aam added the cherry-pick-review Issue that need cherry pick triage to approve label Jan 27, 2023
@a-siva a-siva added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 27, 2023
@itsjustkevin
Copy link
Contributor

@a-siva thoughts on this cherry-pick as it is a medium risk?

@HayesGordon HayesGordon mentioned this issue Jan 30, 2023
Closed
@a-siva
Copy link
Contributor

a-siva commented Jan 30, 2023

lgtm

@HayesGordon HayesGordon mentioned this issue Feb 1, 2023
Closed
@HayesGordon
Copy link

@itsjustkevin and @a-siva Can we get this in please 🙏

It's impacting a lot of people

@andrewpmoore andrewpmoore mentioned this issue Feb 2, 2023
Closed
@itsjustkevin itsjustkevin added merge-to-stable cherry-pick-approved Label for approved cherrypick request labels Feb 3, 2023
@itsjustkevin
Copy link
Contributor

Thanks for the cherry-pick @aam

@whesse
Copy link
Contributor

whesse commented Feb 3, 2023

The cherry-pick still needs to be landed by the author

@itsjustkevin
Copy link
Contributor

@aam you are free to land the change as it has been approved!

@aam
Copy link
Contributor Author

aam commented Feb 3, 2023

@aam you are free to land the change as it has been approved!

Yes, I pressed the button about 40 minutes ago, it runs through presubmit checks now

@mikeesouth
Copy link

mikeesouth commented Feb 7, 2023 •
edited
Loading

Not sure why this is still open. Is this merged so it will land in Flutter 3.7.2?

@whesse
Copy link
Contributor

whesse commented Feb 7, 2023

It is merged, but the stable releases haven't been built and published yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@aam @vsmenon @whesse @a-siva @itsjustkevin @mit-mit @HayesGordon @mikeesouth @athomas