[breaking change] Mark four more classes in dart:async as interface

[lrhn]

Change Intent

Mark interface classes as interface, for consistency with other similar classes.

The StreamConsumer, StreamIterator, StreamTransformer and MultiStreamController classes from dart:async are abstract classes with only abstract members.
As such, for consistency and showing intent, they should have been made abstract interface declarations like other similar classes.

Justification

The classes were missed in the initial marking with modifiers, for some reason. (Likely oversight, they're all far down in a very long file. Mea culpa.)
It would be consistent with other similar classes to mark them as interface, and it would express the intent of the class.

It's not a necessary change. We can keep them as-is, but it's inconsistent, and will only become harder to fix if we wait.

Impact

Low impact. Two known occurrences of extends StreamConsumer in packages (one of them is our own package, which we can quickly change), and we can propose a patch before they have a chance to release a 3.0 compatible version of the package.

Because the changed library is a platform library, the change will not affect pre-3.0 libraries at all!

If released in Dart 3.0.1, we can should keep the window for someone adding a new extends OneOfTheseInterfaces dependency and releasing it with a 3.0.0 language version, very small.

Mitigation

It's not breaking to code existing before today, but it may (hypothetically) break code released between today (3.0 launch) and when the change is released (hopefully 3.0.1).

There are two known non-SDK uses which extends these classes (based on searching internal use), in packages http_server and streams.

• The http_server package is discontinued and archived, so it will never have a 3.0 language release.
• The streams package (flutter_stream_extensions) usage is only in a test, so even if they release a 3.0 version, it won't break users, and the developers can take a patch to fix it at any time. It seem to be developed inside Google, so maybe I can fix it directly.

[lrhn]

Change CL: https://dart-review.googlesource.com/c/sdk/+/302204

[kevmoo]

SGTM!

[itsjustkevin]

@vsmenon @grouma and @Hixie breaking change request.

[Hixie]

fine by me

[grouma]

LGTM

[lrhn]

Ping.

[vsmenon]

lgtm

[lrhn]

Change has landed and cherry-pick to stable has landed too.

[simolus3]

It seems like this change request has never been posted to [email protected] (I can't find in the archives FWIW) - if that's not supposed to be a reliable source for breaking change requests, is there another channel to subscribe?

This breaks one of my packages with quite a few dependents (including packages maintained by the Dart team!). So it would have been nice to know about this a couple months ago 🙃
Edit: Seems like only one version of that package is broken since older versions aren't using Dart 3 as a language version. Still, it would be nice to reliably get informed about upcoming breaking changes somewhere.