Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Clear watcher subscriptions to avoid leaking package:watcher data #52791

Closed
srawlins opened this issue Jun 26, 2023 · 3 comments
Closed

[CP] Clear watcher subscriptions to avoid leaking package:watcher data #52791

srawlins opened this issue Jun 26, 2023 · 3 comments
Assignees
@vsmenon @whesse @itsjustkevin @mit-mit @athomas
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@srawlins
Copy link
Member

Commit(s) to merge

5aee0f6

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/311466

Issue Description

Prior to this fix, there is a fairly significant memory leak in the Dart analyzer that increases used memory when edits to a pubspec.yaml file are made. This fix closes the leak.

What is the fix

The fix is to cancel subscriptions more aggresively.

Why cherry-pick

This memory leak represents a big area of complaint for existing users.

Risk

low

Issue link(s)

#52447

Extra Info

No response
@srawlins srawlins added the cherry-pick-review Issue that need cherry pick triage to approve label Jun 26, 2023
@a-siva a-siva added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jul 5, 2023
@srawlins
Copy link
Member Author

How we doin?

@mit-mit
Copy link
Member

mit-mit commented Jul 10, 2023

SGTM

@itsjustkevin itsjustkevin added cherry-pick-approved Label for approved cherrypick request merge-to-stable labels Jul 10, 2023
@srawlins
Copy link
Member Author

Thanks much!

@itsjustkevin itsjustkevin added the cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@whesse whesse

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. cherry-pick-approved Label for approved cherrypick request cherry-pick-merged Cherry-pick has been merged to the stable or beta branch. cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@srawlins @vsmenon @whesse @a-siva @itsjustkevin @mit-mit @athomas