Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling for linter package in generate_package_config #53400

Closed
whesse opened this issue Aug 31, 2023 · 1 comment
Closed

Remove special handling for linter package in generate_package_config #53400

whesse opened this issue Aug 31, 2023 · 1 comment
Assignees
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@whesse
Copy link
Contributor

whesse commented Aug 31, 2023

The linter package has been moved from third_party/pkg/linter in DEPS to pgk/linter in the repo.

A workaround was added to generate_package_config to handle the case that both copies of linter were present.

Linter was removed from DEPS on 2023/08/28, so we can remove this workaround about one week later.
All the bots should have refreshed, and removed it from their caches.
Developers may still have a copy in third_party unless they have run "gclient sync -D". They will have
seen warning messages saying that linter has been removed, and to run this command, if they
have synced since it was removed from DEPS.

I don't think an added warning, besides the one that already comes from gclient sync and the failure
of generate_package_config, saying the the linter package was found in two places, is needed.

Move of linter into the Dart SDK repo is tracked at (closed) issue:
dart-lang/linter#4411

@whesse whesse added area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. analyzer-linter Issues with the analyzer's support for the linter package labels Aug 31, 2023
@whesse whesse self-assigned this Aug 31, 2023
@parlough
Copy link
Member

parlough commented Jul 1, 2024

Fixed by 979f5d0

@parlough parlough closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Development

No branches or pull requests

2 participants