Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev_sdk_deps tool links PR ids to SDK issues #53857

Closed
parlough opened this issue Oct 25, 2023 · 0 comments
Closed

rev_sdk_deps tool links PR ids to SDK issues #53857

parlough opened this issue Oct 25, 2023 · 0 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@parlough
Copy link
Member

parlough commented Oct 25, 2023

Currently the rev_sdk_deps.dart tool includes the full commit messages from the git log, but these often include PR IDs at the end. For example in 540b3a8:

lints (https://github.com/dart-lang/lints/compare/975c687..2cf8403):
  2cf8403  2023-10-23  Devon Carew  ... (#165)
                                         ^^^^

GitHub automatically links these to issues/PRs in the SDK repository, and (incorrectly) indicates on the issue that the DEPS rev commit referenced it. For example, the earlier example linked to #165.

If a pull request is the last item present in the commit message, the tool should be updated to either:

  1. Find and replace it with a prefixed version (In this case, prefix ID with https://github.com/dart-lang/lints/pulls)
  2. Find and replace it with a version using inline code syntax (In this case, replace (#165) with `(#165)`)
  3. Remove the PR id completely.

I think the first is preferable so those referring to the DEPS rev commits have easy access to the associated pull requests, but all are better than the current state :)

@mit-mit mit-mit added the area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. label Oct 25, 2023
@parlough parlough assigned parlough and unassigned devoncarew Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

3 participants