You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the rev_sdk_deps.dart tool includes the full commit messages from the git log, but these often include PR IDs at the end. For example in 540b3a8:
GitHub automatically links these to issues/PRs in the SDK repository, and (incorrectly) indicates on the issue that the DEPS rev commit referenced it. For example, the earlier example linked to #165.
If a pull request is the last item present in the commit message, the tool should be updated to either:
Find and replace it with a prefixed version (In this case, prefix ID with https://github.com/dart-lang/lints/pulls)
Find and replace it with a version using inline code syntax (In this case, replace (#165) with `(#165)`)
Remove the PR id completely.
I think the first is preferable so those referring to the DEPS rev commits have easy access to the associated pull requests, but all are better than the current state :)
The text was updated successfully, but these errors were encountered:
Currently the
rev_sdk_deps.dart
tool includes the full commit messages from thegit log
, but these often include PR IDs at the end. For example in 540b3a8:GitHub automatically links these to issues/PRs in the SDK repository, and (incorrectly) indicates on the issue that the DEPS rev commit referenced it. For example, the earlier example linked to #165.
If a pull request is the last item present in the commit message, the tool should be updated to either:
https://github.com/dart-lang/lints/pulls
)(#165)
with`(#165)`
)I think the first is preferable so those referring to the DEPS rev commits have easy access to the associated pull requests, but all are better than the current state :)
The text was updated successfully, but these errors were encountered: