Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server performance by decreasing the number of Analysis context's created #53874

Closed
2 of 3 tasks
keertip opened this issue Oct 26, 2023 · 10 comments
Closed
2 of 3 tasks
Assignees
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-performance Issue relates to performance or code size

Comments

@keertip
Copy link
Contributor

keertip commented Oct 26, 2023

We have seen the analysis server consume large memory such that it is rendered unusable.
#52447
#41793

Reducing the number of AnalysisContext's creates and used when analyzing user code will result in improvement of performance and memory usage.

Two arcs of work have been identified as a way to reduce the number of contexts

@keertip keertip added P1 A high priority bug; for example, a single project is unusable or has many test failures area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-server type-performance Issue relates to performance or code size labels Oct 26, 2023
@pq pq assigned pq and keertip Feb 2, 2024
@srawlins
Copy link
Member

Okie doke, P1 issue, any recent updates?

@pq
Copy link
Member

pq commented Feb 28, 2024

Context work is waiting for #54858. Maybe @keertip can speak to the monorepo bits?

@keertip
Copy link
Contributor Author

keertip commented Feb 29, 2024

The monorepo work in the analyzer has landed and awaiting the pub work to be done so that it can be tested. Pub work is tracked in dart-lang/pub/#4127

@bwilkerson
Copy link
Member

Any updates?

@pq
Copy link
Member

pq commented Mar 18, 2024

Context work is still in progress. There are some bot failures I'm still trying to reproduce under test (#54858).

@bwilkerson
Copy link
Member

Any updates?

@pq
Copy link
Member

pq commented Apr 15, 2024

We're wating for https://dart-review.googlesource.com/c/sdk/+/362442 to fully make it through a flutter roll before we can turn on multi-option contexts (see #55413).

@pq
Copy link
Member

pq commented Apr 23, 2024

22da6ed flips the bit for multi-option contexts, but we've reverted related changes twice so I think we want to let it bake for a few more days at least before declaring victory.

@bwilkerson
Copy link
Member

Any progress?

I know that we're waiting for @keertip to test the monorepo support, but I believe the analysis options work is done. Is that correct?

@pq
Copy link
Member

pq commented May 22, 2024

Yep. I think the analysis options work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-performance Issue relates to performance or code size
Projects
None yet
Development

No branches or pull requests

4 participants