Can't build dart VM with gcc 4.5 again

[DartBot]

This issue was originally filed by [email protected]

---

What steps will reproduce the problem?

1. use gcc v4.5
2. Clean checkout of bleeding_edge standalone dart vm
3. cd runtime && ../tools/build.py --arch=ia32
    

What is the expected output? What do you see instead?

Expected output: sucessful biuld
I see:
cc1plus: warnings being treated as errors
../runtime/vm/dart_api_impl.cc: In function 'void* dart::Dart_NewExternalString8(uint8_t*, intptr_t, void*, void ()(void))':
../runtime/vm/dart_api_impl.cc:909:76: error: declaration of 'void* dart::Dart_NewExternalString8(uint8_t*, intptr_t, void*, void ()(void))' with C language linkage
../runtime/include/dart_api.h:768:25: error: conflicts with previous declaration 'void* Dart_NewExternalString8(const uint8_t*, intptr_t, void*, void ()(void))'
../runtime/vm/dart_api_impl.cc: In function 'void* dart::Dart_NewExternalString16(uint16_t*, intptr_t, void*, void ()(void))':
../runtime/vm/dart_api_impl.cc:920:77: error: declaration of 'void* dart::Dart_NewExternalString16(uint16_t*, intptr_t, void*, void ()(void))' with C language linkage
../runtime/include/dart_api.h:773:25: error: conflicts with previous declaration 'void* Dart_NewExternalString16(const uint16_t*, intptr_t, void*, void ()(void))'
../runtime/vm/dart_api_impl.cc: In function 'void* dart::Dart_NewExternalString32(uint32_t*, intptr_t, void*, void ()(void))':
../runtime/vm/dart_api_impl.cc:931:77: error: declaration of 'void* dart::Dart_NewExternalString32(uint32_t*, intptr_t, void*, void ()(void))' with C language linkage
../runtime/include/dart_api.h:778:25: error: conflicts with previous declaration 'void* Dart_NewExternalString32(const uint32_t*, intptr_t, void*, void ()(void))'
make: *** [out/Debug_ia32/obj.target/libdart_api/runtime/vm/dart_api_impl.o] Error 1
make: *** Waiting for unfinished jobs....
make -j 6 BUILDTYPE=Debug_ia32 all
BUILD FAILED

What version of the product are you using? On what operating system?
Ubuntu 11.04, gcc 4.5

Please provide any additional information below.
It looks like the build was broken at r1679

See diff:
dart_api.h
http://code.google.com/p/dart/source/diff?spec=svn1691&r=1679&format=side&path=/branches/bleeding_edge/dart/runtime/include/dart_api.h&old_path=/branches/bleeding_edge/dart/runtime/include/dart_api.h&old=1635

dart_api_impl.cc
http://code.google.com/p/dart/source/diff?spec=svn1691&r=1679&format=side&path=/branches/bleeding_edge/dart/runtime/vm/dart_api_impl.cc&old_path=/branches/bleeding_edge/dart/runtime/vm/dart_api_impl.cc&old=1643

Apparently, const qualifiers before "uintXX_t* codepoints" are missing in
Dart_NewExternalString8
Dart_NewExternalString16
Dart_NewExternalString32

definitions in dart_api_impl.cc

[ghost]

Set owner to @lexprfuncall.
Added Area-VM, Triaged labels.

[iposva-google]

cc @lexprfuncall.
Set owner to @a-siva.

[a-siva]

https://code.google.com/p/dart/source/detail?r=1716

---

Added Fixed label.