Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM calls embedder supplied isolate group cleanup callback when the vm-isolate shuts down #54199

Closed
dnfield opened this issue Nov 30, 2023 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@dnfield
Copy link
Contributor

dnfield commented Nov 30, 2023

Take the test from flutter/engine#48478, or really any of the tests in that file that create an isolate group.

Add the --trace-shutdown flag to the VM

Add a log to DartIsolate::DartIsolateGroupCleanupCallback or observe the timeline.

Observe that DartIsolate::DartIsolateGroupCleanupCallback is called twice, once for the group that's created shutting down (main) and a second time for the vm-isolate. On the second call the isolate_data parameter is nullptr.

This is harmless for Flutter right now but a bit confusing, and could lead to problems if we added more code to our cleanup callback.

/cc @mkustermann fyi since we talked about this in chat.

@lrhn lrhn added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

2 participants